Align handling of flaky arm unittests #7669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removes uses of torch_manual_seed which previously fixed the random state. - Adds pytest plugin pytest-rerunfailures to mark flaky tests. - Refactors flaky tests to use data generators in favor of pregenerated data, which ensures that data is randomized between reruns. - Updates layer_norm testcase to use same qtol value for TOSA/EthosU targets. Note that fixing the randomness may lead to that we will see more flakyness in CI, this will have to be adressed with the flaky mark on a case by case basis over time. Change-Id: I15aa8b517bec2a748b93b0d74e09e2f48df40926
AdrianLundell
added
partner: arm
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7669
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Cancelled Job, 1 PendingAs of commit 738a696 with merge base 4796da7 ( NEW FAILURE - The following job has failed:
CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Collaborator
Author
|
Looking into unittest-arm/linux-job errors, others are unrelated: |
Collaborator
Author
|
I'll have to wait with this until CI is fixed, do not merge. |
zingo
approved these changes
Jan 20, 2025
Collaborator
|
Macos and phi fails seems unrealted. |
Collaborator
|
@digantdesai This touch a file outside arm folder is it OK to merge? |
Collaborator
Author
|
Now only unrelated CI errors left! |
Collaborator
Author
|
@digantdesai What do you think, is it ok to add the new pytest-rerunfailures dependency? |
digantdesai
reviewed
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that fixing the randomness may lead to that we will see more flakyness in CI, this will have to be adressed with the flaky mark on a case by case basis over time.